Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve burrow 0.30.2 support #804

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Conversation

itling
Copy link
Contributor

@itling itling commented Apr 17, 2020

Improve burrow 0.30.2 support

@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2020

This pull request introduces 2 alerts when merging d7f0564 into 4a9c6d4 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect
  • 1 for Superfluous trailing arguments

@itling itling force-pushed the master branch 6 times, most recently from 29e030f to 5a7a3e5 Compare April 17, 2020 11:36
@aklenik
Copy link
Contributor

aklenik commented Apr 17, 2020

@itling Thanks for the adapter update! 👍
Would you like to add a CI integration test for Burrow? The benchmark sample you submitted to the other repo would do it. Take a look at the other CI tests in the packages/caliper-test-integration directory.

@itling
Copy link
Contributor Author

itling commented Apr 18, 2020

@aklenik
I have already submitted the benchmark sample to the other repo. I don’t have time to write CI test case for the time being, it may not be submitted so quickly.

@aklenik aklenik merged commit 2c55b6d into hyperledger-caliper:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants