Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile for global modules #795

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

aklenik
Copy link
Contributor

@aklenik aklenik commented Apr 9, 2020

Signed-off-by: Attila Klenik [email protected]

  • The core module is installed explicitly, so it's placed at the root of the global node_modules folder. The other core deps are deduped to this.
  • NODE_PATH is set to the global node_modules folder, so external modules (like the workload module) can require it without explicitly installing it as its own dependency (and possibly breaking singleton patterns, since that'll be a different module).

Copy link
Contributor

@nklincoln nklincoln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@aklenik aklenik merged commit 1d1e759 into hyperledger-caliper:master Apr 9, 2020
@aklenik aklenik deleted the fix-dockerfile branch April 17, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants