Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a circular array of txPromises #794

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

nklincoln
Copy link
Contributor

@nklincoln nklincoln commented Apr 9, 2020

Signed-off-by: [email protected] [email protected]

Closes #729

  • uses a circular array with a maximum size that will act to overwrite previous entries once the maxLength is reached
  • maxLength made configurable within the config (default 100) under the worker, since the worker is issuing the txns

Open to thoughts on the default maxTxn size, I picked 100 as an initial number, but perhaps should be higher?

Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small issue

packages/caliper-core/lib/common/config/Config.js Outdated Show resolved Hide resolved
@nklincoln nklincoln force-pushed the long-running-test branch from 1aca87e to b94efae Compare April 9, 2020 13:37
@aklenik aklenik merged commit 06a0f82 into hyperledger-caliper:master Apr 9, 2020
@nklincoln nklincoln deleted the long-running-test branch June 25, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long-running test fails with RangeError: Too many elements passed to Promise.all
2 participants