Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove whitespace between CPU% and (val) #718

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

nklincoln
Copy link
Contributor

@nklincoln nklincoln commented Jan 30, 2020

Signed-off-by: [email protected] [email protected]

Additional columns were appearing in report file- this was a result of non-matching column names :

  • CPU% (max) and CPU%(max)
  • CPU% (av) and CPU%(av)

Fix is to remove the whitespace so that they all match - we also do not need to normalize on % values (🤦‍♂ )

Pre-fix
Screenshot 2020-01-30 at 14 09 15

post-fix
Screenshot 2020-01-30 at 14 08 59

corresponding report
Screenshot 2020-01-30 at 14 11 01

Copy link
Contributor

@lynn14m lynn14m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nklincoln nklincoln merged commit 89375bc into hyperledger-caliper:master Jan 31, 2020
@nklincoln nklincoln deleted the fix-stats branch April 8, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants