Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openapi-validation for corda plugin #1294

Merged

Conversation

elenaizaguirre
Copy link
Contributor

@elenaizaguirre elenaizaguirre commented Sep 1, 2021

add missing validation for corda plugin rest endpoints

Closes: #1293

Closes: #847

Signed-off-by: Elena Izaguirre [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1294 (05f224b) into main (93360e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1294   +/-   ##
=======================================
  Coverage   70.04%   70.04%           
=======================================
  Files         368      368           
  Lines       14108    14108           
  Branches     1701     1701           
=======================================
  Hits         9882     9882           
  Misses       3298     3298           
  Partials      928      928           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93360e1...05f224b. Read the comment docs.

@elenaizaguirre elenaizaguirre force-pushed the openapi-validation-corda branch from 05f224b to f6cf6c3 Compare November 12, 2021 09:03
@elenaizaguirre elenaizaguirre force-pushed the openapi-validation-corda branch 3 times, most recently from 1223c90 to b8286bb Compare November 16, 2021 12:45
removed old classes from corda server model

Signed-off-by: Elena Izaguirre <[email protected]>
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elenaizaguirre LGTM, thank you!

@petermetz petermetz merged commit 21fc5ba into hyperledger-cacti:main Nov 24, 2021
@petermetz petermetz deleted the openapi-validation-corda branch November 24, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants