Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test-tooling): containers#getById and #waitForHealthCheck #471

Closed
petermetz opened this issue Jan 13, 2021 · 0 comments · Fixed by #472
Closed

feat(test-tooling): containers#getById and #waitForHealthCheck #471

petermetz opened this issue Jan 13, 2021 · 0 comments · Fixed by #472
Assignees
@petermetz
Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Milestone
v0.4.0

Comments

@petermetz
Copy link
Contributor

Add two utility functions to the class called Containers in the cactus-test-tooling package:

  1. public static async waitForHealthCheck(containerId: string, timeoutMs: number = 180000): Promise

Awaits until a container identified by the containerId
parameter becomes healthy.

  1. public static async getById(containerId: string): Promise

Utility method to obtain the ContainerInfo typed
object from the dockerode library that contains
the status information of the container among
other things.

cc: @takeutak @hartm @sfuji822 @jonathan-m-hamilton
@petermetz petermetz added enhancement New feature or request good-first-issue Good for newcomers Developer_Experience Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. labels Jan 13, 2021
@petermetz petermetz added this to the v0.4.0 milestone Jan 13, 2021
@petermetz petermetz self-assigned this Jan 13, 2021
petermetz added a commit to petermetz/cacti that referenced this issue Jan 13, 2021
@petermetz
feat(test-tooling): containers#getById and #waitForHealthCheck
8b66b6c 
Adds two utility functions to the class called Containers:

1. public static async waitForHealthCheck(containerId: string, timeoutMs: number = 180000): Promise<void>

Awaits until a container identified by the containerId
parameter becomes healthy.

2. public static async getById(containerId: string): Promise<ContainerInfo>

Utility method to obtain the ContainerInfo typed
object from the dockerode library that contains
the status information of the container among
other things.

Fixes hyperledger-cacti#471

Signed-off-by: Peter Somogyvari <[email protected]>
(cherry picked from commit f52626e)
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Jan 13, 2021
Merged
petermetz added a commit that referenced this issue Jan 14, 2021
@petermetz
feat(test-tooling): containers#getById and #waitForHealthCheck
4a7fbfe 
Adds two utility functions to the class called Containers:

1. public static async waitForHealthCheck(containerId: string, timeoutMs: number = 180000): Promise<void>

Awaits until a container identified by the containerId
parameter becomes healthy.

2. public static async getById(containerId: string): Promise<ContainerInfo>

Utility method to obtain the ContainerInfo typed
object from the dockerode library that contains
the status information of the container among
other things.

Fixes #471

Signed-off-by: Peter Somogyvari <[email protected]>
(cherry picked from commit f52626e)
Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
Developer_Experience enhancement New feature or request good-first-issue Good for newcomers Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label.
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

feat(test-tooling): containers#getById and #waitForHealthCheck petermetz/cacti
1 participant
@petermetz