style(cmd-api-server): fix any linter in getOrCreateWebServices()

[Yogesh01000100]

Description:

This pull request addresses issue #2676 by fixing an Unexpected any linter warning in the getOrCreateWebServices() method of the ApiServer class. The warning occurred due to a typecast using (app as any).

Changes:

Replaced (app as any) with (app as express.Express)[httpVerbPrometheus as keyof express.Express](httpPathPrometheus, prometheusExporterHandler);

Importance of keyof:

The use of keyof here is crucial because it ensures that httpVerbPrometheus and httpVerb are treated as the valid key of the express.Express type. This is necessary because HTTP verbs, like GET, POST, PUT etc... should be treated as keys within the express.Express type. By casting httpVerbPrometheus as keyof express.Express, we enforce type safety and prevent potential runtime errors that could occur if an invalid HTTP verb is used. In essence, it ensures that only valid HTTP verbs are accepted, improving the robustness of the code.

Benefits:

This change enhances code readability and maintainability using appropriate types and expressions.

[jagpreetsinghsasan]

Thankyou for the PR, @Yogesh01000100
This looks good to me !

[petermetz]

@Yogesh01000100 Thank you! This is fine to fix the linter warnings themselves so LGTM (just commenting instead of explicit approval to avoid accidental pre-quorum merge).

For fixing it with runtime type validation baked in, please look at the 2 PRs I just opened We'll merge your first because the linter fixes here are legit and then my 2 PRs coming after it will extend the fix with the runtime type validation. This is just an FYI in case you have the time & willingness to look into the extended solution.

[izuru0]

LGTM