Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonce as integer for preloaded contracts #7850

Merged
merged 7 commits into from
Nov 5, 2024
Merged

nonce as integer for preloaded contracts #7850

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e23efc6
fixes #7749
vaidikcode Nov 3, 2024
7c13f5a
Merge branch 'main' into fix-#7749
vaidikcode Nov 4, 2024
2e1b6df
tests
vaidikcode Nov 4, 2024
e5e844d
Merge remote-tracking branch 'origin/fix-#7749' into fix-#7749
vaidikcode Nov 4, 2024
7d574a9
spotless format fix
vaidikcode Nov 4, 2024
d08459a
Merge branch 'main' into fix-#7749
macfarla Nov 4, 2024
d64e25c
Merge branch 'main' into fix-#7749
fab-10 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/src/main/java/org/hyperledger/besu/config/GenesisReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public Stream<GenesisAccount> streamAllocations() {
final var on = normalizeKeys((ObjectNode) entry.getValue());
return new GenesisAccount(
Address.fromHexString(entry.getKey()),
JsonUtil.getString(on, "nonce").map(ParserUtils::parseUnsignedLong).orElse(0L),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to add a test that verifies the desired behaviour.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macfarla Sure, I will begin working on it right away.

JsonUtil.getValueAsString(on, "nonce").map(ParserUtils::parseUnsignedLong).orElse(0L),
JsonUtil.getString(on, "balance")
.map(ParserUtils::parseBalance)
.orElse(Wei.ZERO),
Expand Down