For test node runners use provided data storage config #7495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fab-10
approved these changes
Aug 20, 2024
Signed-off-by: Matthew Whitehead <[email protected]>
matthew1001
force-pushed
the
test-node-runners
branch
from
7bcc4f0 to
e0c8e99
Compare
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
) Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update the test node runners to use whatever the test has configured for data storage config, not hard-coded FOREST defaults
Looking at the test code the tests all configure the node's configuration with the FOREST default anyway, so this change should have no affect on its own but it allows tests to pass in BONSAI and have that setting honoured (e.g. see draft PR #7496 which requires this PR)