5098 branch 16 update invalid enode and excess blob gas params #7457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matilda Clerke <[email protected]>
…ion, apply spotless Signed-off-by: Matilda Clerke <[email protected]>
…ion, apply spotless Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…-branch-2-update-invalid-accounts-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…ounts-params' into 5098-branch-2-update-invalid-accounts-params
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
Signed-off-by: Matilda Clerke <[email protected]>
…' into 5098-branch-3-update-invalid-address-hash-params
…rams' into 5098-branch-4-update-invalid-address-params
Signed-off-by: Matilda-Clerke <[email protected]>
…ams' into 5098-branch-11-update-invalid-block-hash-params
…ams' into 5098-branch-12-update-invalid-block-index-and-number
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…ock-hash-params' into 5098-branch-11-update-invalid-block-hash-params
…ams' into 5098-branch-12-update-invalid-block-index-and-number
…d-number' into 5098-branch-13-update-invalid-call-consolidation-and-privacy-group
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…ATION_PARAMS Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…ne-params Signed-off-by: Matilda-Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
…ss-blob-gas-params Signed-off-by: Matilda-Clerke <[email protected]>
…ss-blob-gas-params
…ss-blob-gas-params
macfarla
approved these changes
Aug 15, 2024
| @@ -64,7 +64,7 @@ protected ValidationResult<RpcErrorType> validateParameters( | |||
| } | |||
| if (payloadParameter.getExcessBlobGas() != null) { | |||
| return ValidationResult.invalid( | |||
| RpcErrorType.INVALID_PARAMS, "non-null ExcessBlobGas pre-cancun"); | |||
| RpcErrorType.INVALID_EXCESS_BLOB_GAS_PARAMS, "Missing excess blob gas field"); | |||
There was a problem hiding this comment.
do we want to keep the "pre-cancun" text
There was a problem hiding this comment.
Can do if you think it's beneficial? These messages are only seen in the logs though.
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
…ledger#7457) * 5098: Add RpcErrorTypes Signed-off-by: Matilda Clerke <[email protected]> * 5098: Modify InvalidJsonRpcParameters and InvalidJsonRpcRequestException, apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Modify InvalidJsonRpcParameters and InvalidJsonRpcRequestException, apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Add JsonRpcParameterException for later use Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update locations for RpcErrorType.INVALID_ACCOUNTS_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Address review comments, apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with changes from branch 1 Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update code to use RpcErrorType.INVALID_ADDRESS_HASH_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update plugin-api gradle hash Signed-off-by: Matilda Clerke <[email protected]> * 5098: Add comment on INVALID_PARAMS_ERROR_CODE Signed-off-by: Matilda Clerke <[email protected]> * 5098: Apply spotless on latest changes Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update code to use RpcErrorType.INVALID_ADDRESS_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken unit test Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken unit test Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_AUTH_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_BLOB_COUNT Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_BLOB_GAS_USED_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_BLOCK_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_BLOCK_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_BLOCK_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update with usage of RpcErrorType.INVALID_BLOCK_COUNT_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken integration test Signed-off-by: Matilda Clerke <[email protected]> * 5098: Add index to exception messages Signed-off-by: Matilda Clerke <[email protected]> * 5098: apoply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update BaseJsonRpcProcessor to utilise RpcErrorType from InvalidJsonRpcParameters Signed-off-by: Matilda Clerke <[email protected]> * 5098: Include parameter index in INVALID_AUTH_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Include parameter index in INVALID_BLOCK_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Include parameter index in INVALID_BLOCK_COUNT_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken integration test Signed-off-by: Matilda Clerke <[email protected]> * 5098: Rename INVALID_AUTH_PARAMS to INVALID_PROPOSAL_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update INVALID_BLOCK_HASH_PARAMS locations Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken unit test Signed-off-by: Matilda Clerke <[email protected]> * 5098: apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_BLOCK_INDEX Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_BLOCK_NUMBER Signed-off-by: Matilda Clerke <[email protected]> * 5098: apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken tests Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_CALL_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_CONSOLIDATION_REQUEST_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_CREATE_PRIVACY_GROUP_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Fix broken test Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_DATA_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_DEPOSIT_REQUEST_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_ENGINE_EXCHANGE_TRANSITION_CONFIGURATION_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_ENGINE_FORKCHOICE_UPDATED_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_ENGINE_PAYLOAD_ATTRIBUTES_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_ENGINE_PAYLOAD_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_ENGINE_PREPARE_PAYLOAD_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Apply spotless Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_ENODE_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Update RpcErrorType.INVALID_EXCESS_BLOB_GAS_PARAMS Signed-off-by: Matilda Clerke <[email protected]> * 5098: Apply spotless Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Matilda-Clerke <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: gconnect <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update to use RpcErrorType.INVALID_ENODE_PARAMS and RpcErrorType.INVALID_EXCESS_BLOB_GAS_PARAMS
Fixed Issue(s)
#5098