Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-2935 Nyota updates #7120

Merged
merged 62 commits into from
May 20, 2024
Merged

EIP-2935 Nyota updates #7120

merged 62 commits into from
May 20, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented May 17, 2024

PR description

Bring implementation up to nyota version of the EIP,
and remove invasive change into the

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

lucassaldanha and others added 30 commits April 18, 2024 11:37
@lucassaldanha
Renamed 7002 contract helper
5b2a34e 
Signed-off-by: Lucas Saldanha <[email protected]>
@lucassaldanha
Huge 7002 update (exits -> withdrawal requests)
ccf2704 
Signed-off-by: Lucas Saldanha <[email protected]>
@lucassaldanha
puglin hash update
4435bc3 
Signed-off-by: Lucas Saldanha <[email protected]>
@lucassaldanha
Updated contract reading to support amount field
7d623b6 
Signed-off-by: Lucas Saldanha <[email protected]>
@lucassaldanha
Updated at
0cb7679 
Signed-off-by: Lucas Saldanha <[email protected]>
@Gabriel-Trintinalia
Remove comments
457f54c 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Merge main into branch
0e3d776 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Introducing temp request class
cad1081 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Introducing Request Decoder
f18528e 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Merge main into branch
4dbf0f8 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix spotless
3b044c6 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix WithdrawalRequest tests
06d4c29 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix not implemented methods
ce12962 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Implement Request encoder
0745b8c 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Renaming missing exists
93a8403 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Change protocol specs to use request validator
0efe067 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix build, javadoc and tests
60a1b3d 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Add requestRoot to Genesis State
573070a 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix spotless
5e148fd 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Change deposit implementation to use general request bus
ec417c4 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix compilation errors and implement builder
bfaa633 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix tests and refactor
7d4cf4c 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix tests
9e10da4 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Fix spotless
0ca1c5f 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Extract methods into a RequestUtil class
13739f2 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Rename variables to match spec
1b7c8f2 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Merge main into branch
7a4ba1b 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Sort processors
6048a1e 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Merge main into branch
5aef960 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
@Gabriel-Trintinalia
Add requests to build processing result so it can be validated
ca116db 
Signed-off-by: Gabriel-Trintinalia <[email protected]>
shemnon and others added 6 commits May 16, 2024 09:34
@shemnon
EIP-3074 gas check
7f87f63 
Check for gas very early in the operation.

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
Merge branch 'pectra-interop' into nyota/auth-gas
9131f4e 
Signed-off-by: Danno Ferrin <[email protected]>
@jframe
Merge pull request hyperledger#117 from shemnon/nyota/auth-gas
ac137c2 
Nyota/auth gas
@shemnon
EIP-2935 devnet-0 gas
2374727 
Charge ridiculous gas for BLOCKHASH

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
EIP-2935 devnet-0 gas
efb90e9 
Warm blockhash

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
EIP-2935 Nyota updates
515d78c 
Bring implementation up to nyota version of the EIP,
and remove invasive change into the

Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon requested review from jflo and Gabriel-Trintinalia and removed request for jflo May 17, 2024 09:19
jflo and others added 3 commits May 17, 2024 14:56
@shemnon shemnon mentioned this pull request May 17, 2024
Merged
jflo and others added 8 commits May 17, 2024 15:27
@jflo
spotless
dc3755f 
Signed-off-by: Justin Florentine <[email protected]>
@shemnon
changes to engine api tests
f380239 
Signed-off-by: Danno Ferrin <[email protected]>
@jflo
frame needs gas
5ec6117 
Signed-off-by: Justin Florentine <[email protected]>
@shemnon
Merge remote-tracking branch 'refs/remotes/jflo/pectra-temp' into nyo…
3093ff0 
…ta/eip2935-nerf

# Conflicts:
#	ethereum/core/src/main/java/org/hyperledger/besu/ethereum/vm/CachingBlockHashLookup.java
#	evm/src/main/java/org/hyperledger/besu/evm/operation/BlockHashOperation.java
@shemnon
Merge remote-tracking branch 'refs/remotes/jflo/pectra-temp' into nyo…
ef2d3d8 
…ta/eip2935-nerf
@shemnon
merge hyperledger#7121
3febf6b 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
gas calculater dead code
d630e8f 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon
merge
6869d98 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon marked this pull request as ready for review May 17, 2024 17:59
macfarla
macfarla approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits on comments only

.../src/main/java/org/hyperledger/besu/ethereum/mainnet/blockhash/PragueBlockHashProcessor.java Outdated Show resolved Hide resolved
.../src/main/java/org/hyperledger/besu/ethereum/mainnet/blockhash/PragueBlockHashProcessor.java Outdated Show resolved Hide resolved
@shemnon
merge and review comments
2645c3e 
Signed-off-by: Danno Ferrin <[email protected]>
@shemnon shemnon enabled auto-merge (squash) May 20, 2024 06:43
@shemnon shemnon merged commit 0cca642 into hyperledger:main May 20, 2024
42 checks passed
jflo added a commit to jflo/besu that referenced this pull request May 28, 2024
@shemnon @lucassaldanha
@Gabriel-Trintinalia @jflo @jframe
EIP-2935 Nyota updates (hyperledger#7120)
67255ce 
Bring implementation up to nyota version of the EIP,
and remove invasive change into the EVM code.

Signed-off-by: Danno Ferrin <[email protected]>

Co-authored-by: Lucas Saldanha <[email protected]>
Co-authored-by: Gabriel-Trintinalia <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
@shemnon @lucassaldanha
@Gabriel-Trintinalia @jflo @jframe @matthew1001
EIP-2935 Nyota updates (hyperledger#7120)
8887dbb 
Bring implementation up to nyota version of the EIP,
and remove invasive change into the EVM code.

Signed-off-by: Danno Ferrin <[email protected]>

Co-authored-by: Lucas Saldanha <[email protected]>
Co-authored-by: Gabriel-Trintinalia <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
jflo added a commit to jflo/besu that referenced this pull request Jun 10, 2024
@shemnon @lucassaldanha
@Gabriel-Trintinalia @jflo @jframe
EIP-2935 Nyota updates (hyperledger#7120)
4d00f63 
Bring implementation up to nyota version of the EIP,
and remove invasive change into the EVM code.

Signed-off-by: Danno Ferrin <[email protected]>

Co-authored-by: Lucas Saldanha <[email protected]>
Co-authored-by: Gabriel-Trintinalia <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Co-authored-by: Jason Frame <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

@Gabriel-Trintinalia Gabriel-Trintinalia Awaiting requested review from Gabriel-Trintinalia

@jflo jflo Awaiting requested review from jflo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shemnon @macfarla @lucassaldanha @Gabriel-Trintinalia @jflo @jframe