Create skeleton structure for Engine API V2 methods #4876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
siladu
added
TeamGroot
siladu
changed the title
jframe
reviewed
Jan 4, 2023
| @@ -491,7 +503,7 @@ private JsonRpcResponse resp( | |||
| new JsonRpcRequestContext( | |||
| new JsonRpcRequest( | |||
| "2.0", | |||
| RpcMethod.ENGINE_FORKCHOICE_UPDATED.getMethodName(), | |||
| RpcMethod.ENGINE_FORKCHOICE_UPDATED_V1.getMethodName(), | |||
There was a problem hiding this comment.
This shouldn't be hard-coded to forkchoiceUpdatedV1. Though the way it's used in the test might mean this doesn't matter so much?
There was a problem hiding this comment.
Good spot. You're right that it doesn't really matter for these, but I've created a getMethodName template for consistency anyway.
I had done something similar for EngineGetPayload but missed this one.
…esponses Refactor AbstractEngineGetPayloadTest to use the same pattern Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Simon Dudley <[email protected]>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
Create AbstractEngineNewPayload and AbstractEngineForkchoiceUpdated, extending with V1 and V2 versions. (AbstractEngineGetPayload and V2 was already introduced in hyperledger@a483f79) Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Create AbstractEngineNewPayload and AbstractEngineForkchoiceUpdated, extending with V1 and V2 versions. (AbstractEngineGetPayload and V2 was already introduced in hyperledger@a483f79) Signed-off-by: Simon Dudley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
First step to implementing https://github.com/ethereum/execution-apis/blob/main/src/engine/shanghai.md
Create AbstractEngineNewPayload and AbstractEngineForkchoiceUpdated, extending with V1 and V2 versions.
(AbstractEngineGetPayload and V2 was already introduced in a483f79)
This will be the basis for parallelising getting a productionised version of the Withdrawals draft onto main.
Fixed Issue(s)
Part of #4776
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog