Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java17 #4532

Closed
wants to merge 201 commits into from
Closed

Java17 #4532

wants to merge 201 commits into from

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Oct 13, 2022

PR description

Taking over @shemnon s work updating Besu to use Java17. This includes updates to gradle configurations and docker container build, as well as the circle ci configuration used.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if
    updates are required.

Changelog

@jflo jflo added the doc-change-required Indicates an issue or PR that requires doc to be updated label Oct 13, 2022
@jflo jflo marked this pull request as draft October 13, 2022 23:08
@siladu siladu mentioned this pull request Oct 14, 2022
@macfarla macfarla mentioned this pull request Oct 19, 2022
2 tasks
garyschulte and others added 24 commits January 10, 2023 15:59
* use optimistictransactiondb for mutable isolated snapshots
* plumbing necessary to have a snapshot specific updater.
* snapshot rolling working
* implement AutoCloseable on BonsaiSnapshotWorldState to ensure we can correctly dispose of snapshots
* add snapshot transaction cloning, change snapshot based worldstate to extend persisted worldstate rather than in-memory worldstate

Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Migrate the build to use Java 17 as the base version.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
turn off missing comment lint
fix header errors

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
run codeql in Java 17
run jdk latest in a new debian version

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
update spotless to avoid opens and exports
update --add-opens for codeql check

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
hyperledger#4516)

* Try to build better block proposals until timeout or GetPayload is called

Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* Remove unused trace options
* move code to array in loop.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
hyperledger#4465)

* BlockCreator returns BlockCreationResult with block and transactions selection results

Signed-off-by: Pedro Novais <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>
* check for self in one more spot

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* upgraded Apache Commons Text to fix CVE-2022-42889

Signed-off-by: Daniel Lehrner <[email protected]>

* add changelog

Signed-off-by: garyschulte <[email protected]>

Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Co-authored-by: garyschulte <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
…perledger#4508)

* During handshake, flip the encrypted message decryption by starting with the new format (EIP-8), and if there is an exception, try the old format. This will reduce the number of exceptions and unnecessary executions.

Signed-off-by: Ameziane H <[email protected]>

* update CHANGELOG.md to give more context on this PR.

Signed-off-by: Ameziane H <[email protected]>

* update CHANGELOG.md to give more context on this PR.

Signed-off-by: Ameziane H <[email protected]>

* Delete some debug code committed by error

Signed-off-by: Ameziane H <[email protected]>

Signed-off-by: Ameziane H <[email protected]>
Signed-off-by: ahamlat <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
shemnon and others added 21 commits January 10, 2023 16:04
* EOF updates

EOF changes tracking Breakout room #4 changes.
Also, add more test coverage.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* prep for 23.1.0-beta

Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
…r#4866)

Custom errorprone checks should not be validating generated code we
cannot change, hence the "method params must be final" errorprone check
will not fire in classes with a "generated" annotation.  This covers
Dagger generated code.

Signed-off-by: Danno Ferrin <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>
Enable EOF into shanghai by wiring it into protocol specs.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Remove the Ropsten, Kiln, Shandong, and Astor network definitions from
the built-in network list.  Includes tendrils depending on and testing
such configurations.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
When Integration tests were migrated to JUnit 5 the gradle configuration was not added.
Fix various tests that had broken in the meantime:
 - NPEs when EnclaveEncryptorType was introduced
 - Account for new future nonce restrictions in the txpool

Signed-off-by: Simon Dudley <[email protected]>
Co-authored-by: Danno Ferrin <[email protected]>
Co-authored-by: Simon Dudley <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
As an example of usecase - this should make it easier to build linux/amd64 images on M1.

Signed-off-by: Jiri Peinlich <[email protected]>

Signed-off-by: Jiri Peinlich <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Create AbstractEngineNewPayload and AbstractEngineForkchoiceUpdated, extending with V1 and V2 versions.
(AbstractEngineGetPayload and V2 was already introduced in hyperledger@a483f79)

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* warning if isQuorum in genesis file is used
* advise use --privacy-enabled instead

Signed-off-by: Sally MacFarlane <[email protected]>
…er#4873)

Add two new development networks and forks, `FutureEips` for EIPs not yet
scheduled for a fork and `ExperimentalEips` for EIPs and other work not yet
accepted to a public network.  Two new fork-named networks are added
like the `dev` network to facilitate easy local development.
These replace the deprecated `Shandong` network and fork.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Move the EOF changes from shanghai into the Cancun fork.

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Zhenyang Shi <[email protected]>

Signed-off-by: Zhenyang Shi <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* disconnect worst peer if best peer is not sufficiently good

Signed-off-by: Sally MacFarlane <[email protected]>
* Withdrawal type
* Withdrawal type encoding and decoding
Signed-off-by: Jason Frame <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Fix a variety of issues found during the fuzzing sprint.

* Validate type length matches code length
* Remove JUMPF from shanghai
* check retf output size
* handle zero length types and code better
* Fix table error on RETURNDATACOPY
* RJUMPV byte should be unsigned
* RJUMPV stack validation fix and more tests
* dead code detection via counting considered bytes
* EVMTool EOF Fuzzing support- remove all alphanumerics (punctuation) and comment lines from code in CLI

Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* Remove qbft reference tests submodule

* Remove snakeyml dependency

Signed-off-by: Jason Frame <[email protected]>

* Revert "Remove snakeyml dependency"

This reverts commit 4ae0dcd.

Signed-off-by: Jason Frame <[email protected]>

Signed-off-by: Jason Frame <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
…ck found (hyperledger#4582)

* add specific error for block by hash lookup not found

Signed-off-by: Sally MacFarlane <[email protected]>

Signed-off-by: Sally MacFarlane <[email protected]>
… other mods in (hyperledger#4895)

The previous evmBuilder override would mean that Shanghai evm configuration is reverted back to Paris

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
* Support Shanghai in Reference Tests

Add support for Shanghai in reference tests
* Add Shanghai and Cancun milestones
* Add "withdrawals" and "withdrawalsRoot" to json objects
* Migrate to schedule by block header.

Signed-off-by: Danno Ferrin <[email protected]>

* Add pending withdrawal code to test case spec

Signed-off-by: Danno Ferrin <[email protected]>

Signed-off-by: Danno Ferrin <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
@shemnon
Copy link
Contributor

shemnon commented Feb 3, 2023

Superseded by #4977?

@siladu
Copy link
Contributor

siladu commented Feb 8, 2023

Superceded by #4977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.