Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

help for --rpc-max-trace-filter-range shows incorrect default #7367

Closed
macfarla opened this issue Jul 23, 2024 · 1 comment · Fixed by #7454
Closed

help for --rpc-max-trace-filter-range shows incorrect default #7367

macfarla opened this issue Jul 23, 2024 · 1 comment · Fixed by #7454
Labels
good first issue Good for newcomers help wanted Extra attention is needed snack Smaller coding task - less than a day for an experienced dev

Comments

@macfarla
Copy link
Contributor

besu -h shows this

  --rpc-max-trace-filter-range=<maxTraceFilterRange>
                         Specifies the maximum number of blocks for the trace_filter method. Must be >=0. 0 specifies no limit  (default: $DEFAULT-VALUE)

rather than the actual default value for --rpc-max-trace-filter-range
@macfarla macfarla added help wanted Extra attention is needed good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev labels Jul 23, 2024
@macfarla
Copy link
Contributor Author

bonus points for adding a unit test that ensures we don't make this mistake again - this literal string $DEFAULT-VALUE should never appear in the help output.

7suyash7 added a commit to 7suyash7/besu that referenced this issue Aug 13, 2024
@7suyash7
Fix hyperledger#7367: Correct default value display for --rpc-max-tra…
6b82fef 
…ce-filter-range along with a test

Signed-off-by: 7suyash7 <[email protected]>
7suyash7 added a commit to 7suyash7/besu that referenced this issue Aug 13, 2024
@7suyash7
Fix hyperledger#7367: Correct default value display for --rpc-max-tra…
092082b 
…ce-filter-range along with a test

Signed-off-by: 7suyash7 <[email protected]>
7suyash7 added a commit to 7suyash7/besu that referenced this issue Aug 13, 2024
@7suyash7
Fix hyperledger#7367: Correct default value display for --rpc-max-tra…
55132cd 
…ce-filter-range along with a test

Signed-off-by: 7suyash7 <[email protected]>
@7suyash7 7suyash7 mentioned this issue Aug 13, 2024
Merged
7suyash7 added a commit to 7suyash7/besu that referenced this issue Aug 13, 2024
@7suyash7
Fix hyperledger#7367: Correct default value display for --rpc-max-tra…
c113d8a 
…ce-filter-range along with a test

Signed-off-by: 7suyash7 <[email protected]>
jframe pushed a commit that referenced this issue Aug 14, 2024
@7suyash7
Correct default --help values (#7454)
adf19af 
* Fix #7367: Correct default value display for --rpc-max-trace-filter-range along with a test
* Fix #7369: Show default value for --genesis-state-hash-cache-enabled

Signed-off-by: 7suyash7 <[email protected]>
gconnect pushed a commit to gconnect/besu that referenced this issue Aug 26, 2024
@7suyash7 @gconnect
Correct default --help values (hyperledger#7454)
60955bd 
* Fix hyperledger#7367: Correct default value display for --rpc-max-trace-filter-range along with a test
* Fix hyperledger#7369: Show default value for --genesis-state-hash-cache-enabled

Signed-off-by: 7suyash7 <[email protected]>
Signed-off-by: gconnect <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct default --help values 7suyash7/besu
1 participant
@macfarla