Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests - update or remove #6739

Open
macfarla opened this issue Mar 15, 2024 · 3 comments
Open

Integration tests - update or remove #6739

macfarla opened this issue Mar 15, 2024 · 3 comments
Labels

Comments

@macfarla
Copy link
Contributor

Make a call on the integration tests
Integration tests - are very out of date. Either update them or remove them if the code is covered elsewhere.

This question can be answered once we have aggregated test coverage #6650

Eg EthCallIntegrationTest - comment on #6661

All the integration tests just null out the parameters (the transaction simulator does pass in real values, so the code is exercised by tests). Should there be at least one integration test that passes in a non-null pair to validate via integration? If not what purpose do the integration tests provide? Should they be removed if they are not keeping pace with the evolution of the APIs they are testing?

@jflo
Copy link
Contributor

jflo commented Apr 8, 2024

I assume this would remove Enclave tests that integrate with a running Tessera started up by testcontainers? That is a pretty large footprint that we could remove.

Copy link

This issue is stale because it has been open for 6 months with no activity.

@github-actions github-actions bot added the Stale label Nov 26, 2024
@jflo jflo added testing and removed Stale labels Nov 26, 2024
@macfarla
Copy link
Contributor Author

I assume this would remove Enclave tests that integrate with a running Tessera started up by testcontainers? That is a pretty large footprint that we could remove.

think these have already been removed (they were ATs) - there's very few Integration Tests actually (like a dozen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants