-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed baseFee option #6335
Comments
@fab-10 is there any code that is used for Linea's fee market that could allow for a fixed fee market in Besu private networks? |
@matthew1001 any interest in this ticket? valuable for side-chains and straightforward config option changes. |
Hi @non-fungible-nelson, possibly, although it would be behind the QBFT/shanghai work and QBFT/empty-block-period work for me, so not likely to come to the top of my list for a little while |
Please review this work #6202 done by @Gabriel-Trintinalia, that could already satisfy your requirement, otherwise could be a good starting point for the development |
For your additional information, here are transactions from my private network (Besu 22.10.2, IBFT2.0) EIP-1559 transaction: https://scan.tokenx-alpha.com/tx/0x44b6d7bc905a2ee131b7873106b45d96500e9f24258b4d00d15c577cd0a7dca0 Legacy transaction: https://scan.tokenx-alpha.com/tx/0x6c1159a020efee86dc47fb3e84cbf44f294f44b3988e8b88471d38b0ad1a1801 Note that either the |
I can take a look at this. |
Could you kindly share if there have been any delightful updates? |
I have issues implementing account abstraction in besu, it is reverting with execution reverted error, I have simulated the same scenario in polygon mumbai, it is working fine but not in besu, is this related to config file params? I am using the london block and qbft. I am not using bundlers for now, created userop and directly interacting with entrypoint contract |
@suraneti Targeting to get the PR out this weekend. Can you also post here a transaction payload that worked for you. |
@manojpramesh Assuming that my network has set the minimum gas price to 100 gwei. Legacy payload {
from: "<FROM_ADDR>",
to: "<TO_ADDR>",
value: "1000000000000000000",
nonce: 0,
gasPrice: "100000000000", // 100 gwei
gasLimit: "21000"
} EIP-1559 payload {
from: "<FROM_ADDR>",
to: "<TO_ADDR>",
value: "1000000000000000000",
nonce: 0,
maxPriorityFeePerGas: "100000000000", // 100 gwei
maxFeePerGas: "100000000000", // 100 gwei
gasLimit: "21000"
} |
@bhargav55, my EIP-4337 setup on Besu includes: Besu version: I've tried several Bundler-Node with Besu, and only Skandha worked. Important note for Skandha: You have to use the |
@suraneti what are the values you are giving for callGasLimit, verificationGasLimit, preVerificationGas inside userOperation object. transaction getting failed with CALL_EXCEPTION'. you can find more details about the issue here #6434. I need help in implementing 4337 in besu network. The similar account abstraction contracts are working in mumbai and fuji |
@manojpramesh I'm looking forward to using this feature and would appreciate an update. Thank you |
I've submitted PR #6562, @non-fungible-nelson @matthew1001 @manojpramesh could you please take a moment to review it when you have the time? I'm unsure whether it's okay or not. I'm new to the Java language |
Awesome contribution 💪🏻 I have asked the engineers to review |
completed in #6562 |
Description
As a developer, I need to enable EIP-1559 on Besu (
IBFT 2.0
non-gas-free network) withzeroBaseFee: true
to prevent a supply-burning mechanism and fixedbaseFee
asgasPrice
value.Currently, I've set
zeroBaseFee: true
. It works fine if I fixedbaseFee
to the same as my network'sgasPrice
. However, when calling theeth_feeHistory
method, it always returns a0
, causing Metamask to estimate invalidmaxBaseFee
andmaxPriority
.I know it sounds strange but I want to integrate some features that require EIP-1559, such as the
Account Abstraction Bundler Node
on my network.Acceptance Criteria
baseFee
to be the same asgasPrice
.eth_feeHistory
, it should return the fixedbaseFee
.Steps to Reproduce (Bug)
zeroBaseFee
.eth_feeHistory
or use a wallet like Metamask to estimate gas.Expected behavior: [What you expect to happen]
zeroBaseFee
should be a constant value asgasPrice
eth_feeHistory
should return non-zero valueActual behavior: [What actually happens]
eth_feeHistory
always return zero valueFrequency: [What percentage of the time does it occur?]
100% on ibft 2.0
Logs (if a bug)
Please post relevant logs from Besu (and the consensus client, if running proof of stake) from before and after the issue.
Versions (Add all that apply)
besu --version
] 22.10.2java -version
] Java-17cat /etc/*release
] AWS LinuxAdditional Information (Add any of the following or anything else that may be relevant)
The text was updated successfully, but these errors were encountered: