Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

priv_call doesn't show a revert message, but "invalid params" #5223

Closed
CMajeri opened this issue Mar 15, 2023 · 5 comments
Closed

priv_call doesn't show a revert message, but "invalid params" #5223

CMajeri opened this issue Mar 15, 2023 · 5 comments
Assignees
Labels
non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT RPC

Comments

@CMajeri
Copy link

CMajeri commented Mar 15, 2023

Description

As an user, I want to see revert messages on priv_call so that I can see errors.

Acceptance Criteria

I run priv_call on a private contract, the call reverts, and I see the revert reason.

Steps to Reproduce (Bug)

  • Create a contract wih a revert in it in a public transaction.
  • Trigger a revert using eth_call.
  • Notice that the revert reason is there.
  • Create the same contract in a private transaction.
  • Call it using priv_call
  • Notice that the revert reason isn't there

^ Is that expected or actually a bug?
I do see the revert reason when the tx gets mined, but I get "invalid params" when I just call it using priv_call.
This is very impractical when simulating calls to see if they'll work before sending them out.

@non-fungible-nelson
Copy link
Contributor

@macfarla - related to RPC cleanup/invalid params? maybe add to #5098 ?

@macfarla macfarla added the non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT label Mar 21, 2023
@NickSneo
Copy link
Contributor

Hey @macfarla , are you working on this issue in your draft PR - #5241 ?

@macfarla
Copy link
Contributor

@NickSneo that PR won't help private transactions, and it's only to expose more details about the "invalid params".
This issue is about the revert reason being hidden for private tx. So I think it's unrelated. Feel free to pick this one up!

@NickSneo
Copy link
Contributor

@macfarla okay cool, thanks! Will pick this up!

@NickSneo
Copy link
Contributor

Closing ticket as issue fixed with MR - #5369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT RPC
Projects
None yet
Development

No branches or pull requests

4 participants