Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tessera ATs - run Tessera as a process #2867

Closed
pinges opened this issue Oct 11, 2021 · 10 comments
Closed

Tessera ATs - run Tessera as a process #2867

pinges opened this issue Oct 11, 2021 · 10 comments
Assignees
Labels
TeamRevenant GH issues worked on by Revenant Team

Comments

@pinges
Copy link
Contributor

pinges commented Oct 11, 2021

When we added the Tessera container tests the time to run the acceptance tests increased.

Currently we are starting a docker container for each of the Besu and Tessera nodes for each test that involves Tessera.

  1. Reuse the docker instances per test class
  2. Make Tessera nodes run in a process/thread like they do in other acceptance tests

Any other ideas?

@pinges pinges added the TeamRevenant GH issues worked on by Revenant Team label Oct 11, 2021
@macfarla
Copy link
Contributor

Alternative idea - run Tessera as a process (requires some changes to Tessera - Stefan had a PR)

@mark-terry
Copy link
Contributor

Option 1:
testcontainers/testcontainers-java#1781

Container reuse in testcontainers is still WIP and appears to have outstanding work around assigning networks. This does not appear to be viable at this point in time.

@MadelineMurray
Copy link
Contributor

@mark-terry - talking about this in planning today. We're going to do with option 2 and can start the work to make this change (ie, it's not blocked).

@pinges is going to link his previous PR using this approach. The previous PR is a MVP approach so this work is about implementing that approach with production quality code.

@MadelineMurray
Copy link
Contributor

There's going to be two PRs - one in Tessera and one in Besu so leaving this issue in the Besu repo rather than moving to Tessera.

@taccatisid
Copy link
Contributor

Going for "Make Tessera nodes run in a process/thread like they do in other acceptance tests"

@macfarla macfarla changed the title Tessera containerTests - investigate options for reusing containers Tessera ATs - run Tessera as a process Nov 17, 2021
@jflo
Copy link
Contributor

jflo commented Nov 17, 2021

Am interested in this, as the PrivacyReorgTest depends on Orion today, and when I swapped it out for Tessera in this pr #3073, I triggered the dependency on testcontainers. That's not a deal breaker per-se, but since it is happening as a unit test instead of an integration/acceptance test, there is no docker daemon running to deploy Tessera to.

@macfarla macfarla mentioned this issue Jan 12, 2022
1 task
@macfarla
Copy link
Contributor

This functionality is now in Tessera. However we need a Tessera release
22.1.1 is current https://github.com/ConsenSys/tessera/releases/tag/tessera-22.1.1
Need 22.1.2 for this

@Gabriel-Trintinalia
Copy link
Contributor

Blocked by Consensys/tessera#1490

@Gabriel-Trintinalia
Copy link
Contributor

Blocked by #4532

Tessera needs Java 17.

@non-fungible-nelson
Copy link
Contributor

@macfarla - anything related to latest tessera AT changes? Close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants