Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable sending of non eip155 replay protected tx by default #1975

Closed
renaynay opened this issue Mar 3, 2021 · 1 comment · Fixed by #2497
Closed

Disable sending of non eip155 replay protected tx by default #1975

renaynay opened this issue Mar 3, 2021 · 1 comment · Fixed by #2497
Labels
enhancement New feature or request mainnet

Comments

@renaynay
Copy link

renaynay commented Mar 3, 2021

Geth recently implemented this change here: ethereum/go-ethereum#22339. It would be nice if Besu would also disable sending of non EIP155 transactions by default (see reasoning in linked PR).
@atoulme
Copy link
Contributor

atoulme commented Mar 3, 2021

Thanks Rene for the report. I believe this is a straightforward change and should be implemented by Besu as well. We can adopt a flag like Geth did to allow non EIP155 transactions, but by default they should be forbidden.

@atoulme atoulme mentioned this issue Mar 4, 2021
Closed
1 task
@mbaxter mbaxter mentioned this issue Jul 4, 2021
Merged
1 task
@vmichalik vmichalik added mainnet enhancement New feature or request labels Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request mainnet
Projects
None yet
Milestone
No milestone
3 participants
@atoulme @vmichalik @renaynay