-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: always initialize mediator #985
feat: always initialize mediator #985
Conversation
Codecov Report
@@ Coverage Diff @@
## main #985 +/- ##
==========================================
- Coverage 88.18% 88.17% -0.01%
==========================================
Files 487 487
Lines 11544 11548 +4
Branches 1921 1921
==========================================
+ Hits 10180 10183 +3
- Misses 1304 1305 +1
Partials 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Add mediationRole property to AgentConfig to ensure MediatorModule is initialized correctly. This prevents concurrency issues when multiple attempts to create a mediatorRoutingRecord fail. Signed-off-by: Niall Shaw <[email protected]>
always initialize mediator Signed-off-by: Niall Shaw <[email protected]>
092f5f7
to
9e82a84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @niallshaw-absa! I've seen that some tests failed. Are they working locally for you? Maybe it'll be needed to update snapshots as now the mediator routing record is created at the start.
Signed-off-by: Niall Shaw <[email protected]>
@genaris - tests are failing for me locally also, if possible can you show me how to update the snapshots? Thanks! |
…eration on init Signed-off-by: Ariel Gentile <[email protected]>
To update snapshots you need to add -u parameter to yarn test. However it was not enough, because this new behaviour implied the generation of a different record each time (as routing key changed), so I've added some mocks on DID generation for that particular test suite. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Always initialize the mediator during
agent.initialize()
, to prevent attempts to initialize twice due to parallelism