feat: delete by record id

[tipusingh]

Fixes #925

Signed-off-by: Tipu Singh [email protected]

[genaris]

Good one! I've left some comments with doubts and suggestions.

[codecov-commenter]

Codecov Report

Merging #983 (4d17369) into main (1eaf995) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
- Coverage   88.18%   88.12%   -0.06%     
==========================================
  Files         487      487              
  Lines       11532    11553      +21     
  Branches     1832     1923      +91     
==========================================
+ Hits        10169    10181      +12     
+ Misses       1359     1310      -49     
- Partials        4       62      +58     

Impacted Files	Coverage Δ
...rc/modules/generic-records/GenericRecordsModule.ts	72.09% <50.00%> (-3.59%)	⬇️
packages/core/src/storage/IndyStorageService.ts	92.62% <50.00%> (-2.21%)	⬇️
packages/core/src/storage/Repository.ts	95.83% <60.00%> (-4.17%)	⬇️
...es/generic-records/service/GenericRecordService.ts	87.09% <75.00%> (-1.80%)	⬇️
packages/node/src/NodeFileSystem.ts	37.14% <0.00%> (ø)
packages/core/src/crypto/JwsService.ts	90.90% <0.00%> (ø)
packages/core/src/agent/MessageSender.ts	87.36% <0.00%> (ø)
packages/core/src/agent/MessageReceiver.ts	80.76% <0.00%> (ø)
packages/core/src/modules/ledger/IndyPool.ts	82.92% <0.00%> (ø)
packages/core/src/modules/proofs/ProofsModule.ts	79.11% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[berendsliedrecht]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs 0 Vulnerabilities 0 Security Hotspots 2 Code Smells

No Coverage information 0.0% Duplication

@TimoGlastra Is this something we added?

[TimoGlastra]

This is great @tipusingh! Left one minor suggestion

[TimoGlastra]

Kudos, SonarCloud Quality Gate passed!   
0 Bugs 0 Vulnerabilities 0 Security Hotspots 2 Code Smells
No Coverage information 0.0% Duplication

@TimoGlastra Is this something we added?

No idea where this is coming from. I'm not really a fan of sonarcloud, as it always annoys you about things that are not really a problem. But happy to keep it in if we think it helps

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
0.0% Duplication

[genaris]

Kudos, SonarCloud Quality Gate passed!   
0 Bugs 0 Vulnerabilities 0 Security Hotspots 2 Code Smells
No Coverage information 0.0% Duplication

@TimoGlastra Is this something we added?

No idea where this is coming from. I'm not really a fan of sonarcloud, as it always annoys you about things that are not really a problem. But happy to keep it in if we think it helps

I've seen that recently it started to run in other projects (such as ACA-Py and aries-mobile-agent-react-native). Could be a group setting?