-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add present proof v2 #979
feat: add present proof v2 #979
Conversation
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
…r/aries-framework-javascript into hyperledger-feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
…r/aries-framework-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Feat/present proof v2
…r/aries-framework-javascript into feat/present-proof-v2
Signed-off-by: NB Prasad Katkar <[email protected]>
Feat/present proof v2
Signed-off-by: NB Prasad Katkar <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
Signed-off-by: NB-Karim <[email protected]>
@NB-MikeRichardson it seems one test is failing, could you take a look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just added some minor comments regarding RevocationNotificationService that I think belongs to Credential Module.
It would be nice if we can integrate here the changes introduced in #972 but if it's too much trouble we can merge it afterwards.
packages/core/src/modules/proofs/__tests__/ProofsModule.test.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/proofs/__tests__/ProofsModule.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #979 +/- ##
=============================================
- Coverage 87.64% 87.55% -0.10%
=============================================
Files 574 602 +28
Lines 13539 14549 +1010
Branches 2194 2350 +156
=============================================
+ Hits 11866 12738 +872
- Misses 1669 1806 +137
- Partials 4 5 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
I haven't merged in #972 because that PR is not yet in 0.3.0-pre. I am happy to merge that it in in due course: I would say let's get this stuff in first as people are waiting on it. |
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Mike Richardson <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Yes I think it would be easier to merge afterwards. I'll merge this PR and we can then update with main (hasn't been done in a while). |
Did someone add sonarcloud? |
Signed-off-by: Timo Glastra <[email protected]>
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Merging as CI for node 14 passes (still the BBS issue) |
Signed-off-by: Mike Richardson <[email protected]> Co-authored-by: NB Prasad Katkar <[email protected]> Co-authored-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Mike Richardson <[email protected]> Co-authored-by: NB Prasad Katkar <[email protected]> Co-authored-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Mike Richardson <[email protected]> Co-authored-by: NB Prasad Katkar <[email protected]> Co-authored-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Mike Richardson <[email protected]> Co-authored-by: NB Prasad Katkar <[email protected]> Co-authored-by: Karim Stekelenburg <[email protected]> Signed-off-by: Ariel Gentile <[email protected]>
This is essentially a three-way merge of
feat/ppv2
0.3.0-pre
TimoGlastra/refactor/generalize-proofs
BREAKING CHANGE: the present proof module has been extended to support both v1 and v2 of protocol. See Migrating from AFJ 0.2.x to 0.3.0 for a detailed migration instructions.