Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generic-records): support custom id property #964

Merged

Conversation

TimoGlastra
Copy link
Contributor

the custom id property was not being used, and an uuid was always generated

@TimoGlastra TimoGlastra requested a review from a team as a code owner July 25, 2022 22:48
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #964 (5e9c7c1) into main (4c87878) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files         475      475           
  Lines       11417    11417           
  Branches     1804     1804           
=======================================
  Hits        10020    10020           
  Misses       1393     1393           
  Partials        4        4           
Impacted Files Coverage Δ
...rc/modules/generic-records/GenericRecordsModule.ts 75.67% <100.00%> (ø)
...es/generic-records/service/GenericRecordService.ts 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@TimoGlastra TimoGlastra merged commit 0f690a0 into openwallet-foundation:main Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants