refactor!: add agent context #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
added
multitenancy
TimoGlastra
force-pushed
the
refactor/add-agent-context-030
branch
from
999a888 to
eae5f82
Compare
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #920 +/- ##
=============================================
+ Coverage 86.51% 86.62% +0.11%
=============================================
Files 512 515 +3
Lines 12468 12542 +74
Branches 2103 2131 +28
=============================================
+ Hits 10787 10865 +78
+ Misses 1585 1582 -3
+ Partials 96 95 -1
Continue to review full report at Codecov.
|
Signed-off-by: Timo Glastra <[email protected]> BREAKING CHANGE: To make AFJ multi-tenancy ready, all services and repositories have been made stateless. A new `AgentContext` is introduced that holds the current context, which is passed to each method call. The public API hasn't been affected, but due to the large impact of this change it is marked as braking. Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
refactor/add-agent-context-030
branch
from
eae5f82 to
017d2b7
Compare
berendsliedrecht
approved these changes
Jul 6, 2022
|
I assume the test will succeed once #935 is merged. |
Yes, locally that's the only tests failing |
|
Merging as the only failed test is the one as fixed in #935 so we can keep the PR review going |
TimoGlastra
added a commit
that referenced
this pull request
Aug 11, 2022
Signed-off-by: Timo Glastra <[email protected]> BREAKING CHANGE: To make AFJ multi-tenancy ready, all services and repositories have been made stateless. A new `AgentContext` is introduced that holds the current context, which is passed to each method call. The public API hasn't been affected, but due to the large impact of this change it is marked as breaking.
TimoGlastra
added a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Timo Glastra <[email protected]> BREAKING CHANGE: To make AFJ multi-tenancy ready, all services and repositories have been made stateless. A new `AgentContext` is introduced that holds the current context, which is passed to each method call. The public API hasn't been affected, but due to the large impact of this change it is marked as breaking.
TimoGlastra
added a commit
that referenced
this pull request
Aug 26, 2022
Signed-off-by: Timo Glastra <[email protected]> BREAKING CHANGE: To make AFJ multi-tenancy ready, all services and repositories have been made stateless. A new `AgentContext` is introduced that holds the current context, which is passed to each method call. The public API hasn't been affected, but due to the large impact of this change it is marked as breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timo Glastra [email protected]
This is the same PR as #881, but based off the 0.3.0-pre branch instead of main. There's no changes compared to #881 except for making it work with this branch (making the new w3c services stateless). Due to the breaking changes we don't want to have this in main just yet.
BREAKING CHANGE: To make AFJ multi-tenancy ready, all services and repositories have been made stateless. A new
AgentContextis introduced that holds the current context, which is passed to each method call. The public API hasn't been affected, but due to the large impact of this change it is marked as breaking.