feat: fetch verification method types by proof type

[karimStekelenburg]

Signed-off-by: Karim [email protected]

[TimoGlastra]

Can you add tests for the added methods?

[karimStekelenburg]

Can you add tests for the added methods?

@TimoGlastra good catch, thanks. Time for a PR checklist.. I'll open a discussion about it.

[TimoGlastra]

This should be KeyType[]. This actually means an array with one item of type KeyType (you can use this to create tuple types)

Suggested change

	keyTypes: [KeyType]
	keyTypes: KeyType[]

[TimoGlastra]

Hmm after thinking about it a bit more. This is the key type as we use it in the framework, but not the key as is used in did documents. Those key types are e.g. Ed25519Key2018 (or something like it). So we still have to make the transformation, but only the signature suites know which actual types is supports.

Should this be updated to include the supported key types as used by did documents? E.g. if the suites only supports 2018 and 2020 ed25519 keys and there's a new 2022 one that isn't supported we should only extract the 2018 and 2020 keys from the did document, as that's the only ones we can sign with.

[TimoGlastra]

LGTM 👍. If you can resolve the conflicts we can merge

[codecov-commenter]

Codecov Report

Merging #913 (f2b2082) into 0.3.0-pre (d2fe29e) will decrease coverage by 0.03%.
The diff coverage is 70.37%.

@@              Coverage Diff              @@
##           0.3.0-pre     #913      +/-   ##
=============================================
- Coverage      87.67%   87.64%   -0.04%     
=============================================
  Files            574      574              
  Lines          13521    13539      +18     
  Branches        2190     2194       +4     
=============================================
+ Hits           11855    11866      +11     
- Misses          1662     1669       +7     
  Partials           4        4              

Impacted Files	Coverage Δ
...ages/core/src/modules/vc/SignatureSuiteRegistry.ts	50.00% <0.00%> (-20.59%)	⬇️
...ore/src/modules/dids/domain/key-type/bls12381g2.ts	100.00% <100.00%> (ø)
...s/core/src/modules/dids/domain/key-type/ed25519.ts	100.00% <100.00%> (ø)
...ckages/core/src/modules/vc/W3cCredentialService.ts	81.56% <100.00%> (+0.53%)	⬆️
packages/core/src/modules/vc/W3cVcModule.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[TimoGlastra]

BBS tests failing in Node.JS 17/18 But otherwise tests are passing. Merging