fix(connections): set image url in create request #896
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit-Padmani <[email protected]>
|
Thanks @Amit-Padmani, can you add a test case for this so it doesn't slip in again? |
Signed-off-by: Amit-Padmani <[email protected]>
|
@TimoGlastra Added |
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
=======================================
Coverage 87.65% 87.65%
=======================================
Files 470 470
Lines 11172 11172
Branches 1781 1781
=======================================
Hits 9793 9793
Misses 1375 1375
Partials 4 4
Continue to review full report at Codecov.
|
TimoGlastra
approved these changes
Jun 21, 2022
TimoGlastra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit-Padmani [email protected]
Image URL is missing in connection record #895