-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(credentials): miscellaneous typing issues #880
fix(credentials): miscellaneous typing issues #880
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 87.57% 87.58% +0.01%
==========================================
Files 463 468 +5
Lines 11083 11092 +9
Branches 1745 1745
==========================================
+ Hits 9706 9715 +9
Misses 1377 1377
Continue to review full report at Codecov.
|
@@ -11,7 +11,7 @@ import { V1CredentialPreview } from './V1CredentialPreview' | |||
|
|||
export const INDY_CREDENTIAL_OFFER_ATTACHMENT_ID = 'libindy-cred-offer-0' | |||
|
|||
export interface OfferCredentialMessageOptions { | |||
export interface V1OfferCredentialMessageOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this is on purpose but we now have eg V1OfferCredentialMessageOptions
and V1IssueCredentialMessageOptions
. So maybe it'd be nice to have V10...
or V1...
consistently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this consistent? V1<PROTOCOL>MessageOptions
, or am I misreading it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Maybe I'm missing sth. Just saw that there is V10.. and V1.. - so maybe there's a reason for this?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think you read th O
in Offer
as a zero. Its V1OfferCredential
and not V10fferCredential
:).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahahah I'm blind. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😇🤦♂️
Fixes some issues encountered in the typing. Mainly:
V1
and `V2 to all credential interfaces to avoid conflicts in interface namesstring
as type forprotocolVersion
instead ofv${string}
to make it work with tsoa