feat(credentials): delete associated didCommMessages #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moriarty <[email protected]>
TimoGlastra
reviewed
Jun 16, 2022
packages/core/src/modules/credentials/services/CredentialService.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/credentials/protocol/v2/__tests__/V2CredentialServiceCred.test.ts
Show resolved
Hide resolved
packages/core/src/modules/credentials/protocol/v1/__tests__/V1CredentialServiceCred.test.ts
Show resolved
Hide resolved
TimoGlastra
changed the title
added 2 commits
June 16, 2022 17:08
code review feedback Signed-off-by: Moriarty <[email protected]>
…associated-didCommMessages Signed-off-by: Moriarty <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #870 +/- ##
=======================================
Coverage 87.56% 87.57%
=======================================
Files 463 463
Lines 11077 11083 +6
Branches 1743 1745 +2
=======================================
+ Hits 9700 9706 +6
Misses 1377 1377
Continue to review full report at Codecov.
|
TimoGlastra
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Moriarty [email protected]
closes #728