Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): parse and validate preview @type #861

Merged

Conversation

TimoGlastra
Copy link
Contributor

Signed-off-by: Timo Glastra [email protected]

Verified

This commit was signed with the committer’s verified signature.
TimoGlastra Timo Glastra
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra requested a review from a team as a code owner June 15, 2022 10:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@TimoGlastra TimoGlastra enabled auto-merge (squash) June 15, 2022 10:27

Verified

This commit was signed with the committer’s verified signature.
TimoGlastra Timo Glastra
Signed-off-by: Timo Glastra <[email protected]>

Verified

This commit was signed with the committer’s verified signature.
TimoGlastra Timo Glastra
…aries-framework-javascript into fix/credential-preview-type

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #861 (a0228bd) into main (58e6603) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files         463      463           
  Lines       11070    11072    +2     
  Branches     1824     1824           
=======================================
+ Hits         9697     9699    +2     
  Misses       1311     1311           
  Partials       62       62           
Impacted Files Coverage Δ
...ntials/protocol/v2/messages/V2CredentialPreview.ts 90.00% <100.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e6603...a0228bd. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 1cc8f46 into openwallet-foundation:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants