Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): use interface in module api #856

Conversation

TimoGlastra
Copy link
Contributor

My previous PR to generalize the crdentials module undid some of the changes to only allow interfaces.

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 15, 2022 08:45
Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimoGlastra TimoGlastra enabled auto-merge (squash) June 15, 2022 09:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #856 (32a4d10) into main (4be8f82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #856   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files         463      463           
  Lines       11070    11070           
  Branches     1824     1824           
=======================================
  Hits         9697     9697           
  Misses       1311     1311           
  Partials       62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be8f82...32a4d10. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 58e6603 into openwallet-foundation:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants