Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): proposal preview attribute #855

Conversation

TimoGlastra
Copy link
Contributor

In the v2 preview credential_proposal should be credential_preview

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 15, 2022 08:06
Copy link
Contributor

@morrieinmaas morrieinmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@berendsliedrecht berendsliedrecht enabled auto-merge (squash) June 15, 2022 08:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #855 (6199e2b) into main (ba03fa0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #855   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files         463      463           
  Lines       11070    11070           
  Branches     1824     1824           
=======================================
  Hits         9697     9697           
  Misses       1311     1311           
  Partials       62       62           
Impacted Files Coverage Δ
...entials/protocol/v2/CredentialFormatCoordinator.ts 89.06% <100.00%> (ø)
...les/credentials/protocol/v2/V2CredentialService.ts 89.25% <100.00%> (ø)
...protocol/v2/messages/V2ProposeCredentialMessage.ts 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba03fa0...6199e2b. Read the comment docs.

@berendsliedrecht berendsliedrecht merged commit 3022bd2 into openwallet-foundation:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants