feat(core): generic repository events #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TimoGlastra
reviewed
Jun 9, 2022
There was a problem hiding this comment.
This is awesome @Przytua, thanks!
It seems CI is failing and there's some eslint warnings but code looks good otherwise
| RecordDeleted = 'RecordDeleted', | ||
| } | ||
|
|
||
| export interface RecordSavedEvent<T extends BaseRecord<any, any, any>> extends BaseEvent { |
There was a problem hiding this comment.
can you disable the eslint warnings for this line?
| } | ||
| } | ||
|
|
||
| export interface RecordUpdatedEvent<T extends BaseRecord<any, any, any>> extends BaseEvent { |
| } | ||
| } | ||
|
|
||
| export interface RecordDeletedEvent<T extends BaseRecord<any, any, any>> extends BaseEvent { |
Przytua
force-pushed
the
feature/generic-repository-events
branch
from
a4259f7 to
180976a
Compare
Signed-off-by: Łukasz Przytuła <[email protected]>
Przytua
force-pushed
the
feature/generic-repository-events
branch
from
180976a to
c48ec8d
Compare
|
@TimoGlastra fixed |
TimoGlastra
approved these changes
Jun 9, 2022
TimoGlastra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723
Added generic
RecordSavedEvent,RecordUpdatedEvent, andRecordDeletedEventemitted fromRepository.