fix(oob): expose parseInvitation publicly #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
berendsliedrecht
commented
Jun 3, 2022
berendsliedrecht
commented
- Quite a nice function to have outside of the framework for parsing qrcodes.
Signed-off-by: Berend Sliedrecht <[email protected]>
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
changed the title
TimoGlastra
approved these changes
Jun 3, 2022
| * | ||
| * @returns OutOfBandInvitation | ||
| */ | ||
| export const parseInvitation = async (invitationUrl: string): Promise<OutOfBandInvitation> => { |
There was a problem hiding this comment.
Suggested change
| export const parseInvitation = async (invitationUrl: string): Promise<OutOfBandInvitation> => { | |
| export const parseInvitationUrl = async (invitationUrl: string): Promise<OutOfBandInvitation> => { |
| 'InvitationUrl is invalid. It needs to contain one, and only one, of the following parameters: `oob`, `c_i` or `d_m`.' | ||
| ) | ||
| public async parseInvitation(invitationUrl: string): Promise<OutOfBandInvitation> { | ||
| return await this.parseInvitation(invitationUrl) |
There was a problem hiding this comment.
This will cause an endless loop it seems?
There was a problem hiding this comment.
Ah it should not be this. good catch haha
Signed-off-by: Berend Sliedrecht <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 87.76% 87.77%
=======================================
Files 439 440 +1
Lines 10854 10862 +8
Branches 1837 1837
=======================================
+ Hits 9526 9534 +8
Misses 1267 1267
Partials 61 61
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.