Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oob): export messages in oob #828

Conversation

berendsliedrecht
Copy link
Contributor

Noticed that the OutofBandInvitation was not exported to the public and it can be quite useful to have

  • Exported the messages folder inside the oob module
  • There might be more items we want to export from here, but I am not too sure about which.

Signed-off-by: Berend Sliedrecht [email protected]

Signed-off-by: Berend Sliedrecht <[email protected]>
@berendsliedrecht berendsliedrecht requested a review from a team as a code owner June 2, 2022 12:25
@TimoGlastra TimoGlastra changed the title fix(core): export messages in oob fix(oob): export messages in oob Jun 2, 2022
@TimoGlastra
Copy link
Contributor

TimoGlastra commented Jun 2, 2022

@blu3beri I've started to use modules as topics to make the commit topics more specific (so oob,credentials,routing,etc.. instead of core). WDYT?

@berendsliedrecht
Copy link
Contributor Author

@blu3beri I've started to use modules as topics to make the commit topics more specific (so oob,credentials,routing,etc.. instead of core). WDYT?

Yes I am a fan. Should we maybe add something in the DEVREADME, or anywhere else, on the topics?

@berendsliedrecht berendsliedrecht enabled auto-merge (squash) June 2, 2022 12:40
@berendsliedrecht berendsliedrecht disabled auto-merge June 2, 2022 12:40
@berendsliedrecht berendsliedrecht enabled auto-merge (squash) June 2, 2022 12:40
@berendsliedrecht berendsliedrecht merged commit 10cf74d into openwallet-foundation:main Jun 2, 2022
@berendsliedrecht berendsliedrecht deleted the fix/export-from-oob branch June 2, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants