Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process ws return route messages serially #826

Merged

Conversation

TimoGlastra
Copy link
Contributor

We were already processing messages serially for pickup v1 and v2. This pr updates to also use this for websocket inbound transport. This can help prevent some race conditions and is consistent with the other pickup approaches

@TimoGlastra TimoGlastra requested a review from a team as a code owner June 1, 2022 15:53
@TimoGlastra
Copy link
Contributor Author

@amanji This should fix the issue with messages being processed in parallel

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #826 (6f14c57) into main (8dd7f80) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main     #826   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files         438      438           
  Lines       10820    10821    +1     
  Branches     1891     1834   -57     
=======================================
+ Hits         9489     9490    +1     
  Misses       1269     1269           
  Partials       62       62           
Impacted Files Coverage Δ
packages/core/src/transport/WsOutboundTransport.ts 11.59% <50.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd7f80...6f14c57. Read the comment docs.

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra enabled auto-merge (squash) June 2, 2022 10:08
@TimoGlastra TimoGlastra merged commit 2831a8e into openwallet-foundation:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants