Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): default for credentials in exchange record #816

Merged
merged 7 commits into from
May 31, 2022

Conversation

NB-MikeRichardson
Copy link
Contributor

No description provided.

@NB-MikeRichardson NB-MikeRichardson requested a review from a team as a code owner May 31, 2022 05:48
@NB-MikeRichardson NB-MikeRichardson changed the title Fix/i793 fix: default credentials to [] in credential exchange record May 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #816 (840dc88) into main (bd1e677) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   87.70%   87.70%   -0.01%     
==========================================
  Files         438      438              
  Lines       10823    10822       -1     
  Branches     1892     1891       -1     
==========================================
- Hits         9492     9491       -1     
  Misses       1269     1269              
  Partials       62       62              
Impacted Files Coverage Δ
...credentials/repository/CredentialExchangeRecord.ts 92.85% <100.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd1e677...840dc88. Read the comment docs.

@TimoGlastra TimoGlastra changed the title fix: default credentials to [] in credential exchange record fix: set default for credentials in credential exchange record May 31, 2022
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 31, 2022 06:53
@TimoGlastra
Copy link
Contributor

@NB-MikeRichardson it looks like the tests are failing now but only because the credentials is added to the snapshot. This is an expected change. If you can try to run the tests with -u again locally it should work.

Signed-off-by: Mike Richardson <[email protected]>
auto-merge was automatically disabled May 31, 2022 07:55

Head branch was pushed to by a user without write access

Signed-off-by: Mike Richardson <[email protected]>
@NB-MikeRichardson
Copy link
Contributor Author

The tests are still failing. No idea why.

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra
Copy link
Contributor

@NB-MikeRichardson ran it locally and worked fine for me, there's probably something broken in your environment?

I've pushed changes and it's ready to merge now!

@TimoGlastra TimoGlastra changed the title fix: set default for credentials in credential exchange record fix(credentials): set default for credentials in credential exchange record May 31, 2022
@TimoGlastra TimoGlastra changed the title fix(credentials): set default for credentials in credential exchange record fix(credentials): default for credentials in exchange record May 31, 2022
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 31, 2022 10:21
@TimoGlastra TimoGlastra merged commit df1a00b into openwallet-foundation:main May 31, 2022
@NB-MikeRichardson NB-MikeRichardson deleted the fix/i793 branch June 2, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants