-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unqualified did from out of band record #782
fix: remove unqualified did from out of band record #782
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #782 +/- ##
==========================================
- Coverage 87.53% 87.47% -0.06%
==========================================
Files 435 435
Lines 10666 10652 -14
Branches 1891 1880 -11
==========================================
- Hits 9336 9318 -18
- Misses 1268 1272 +4
Partials 62 62
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, just some nits about the code nothing blocking or major.
packages/core/src/modules/connections/services/ConnectionService.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/connections/services/ConnectionService.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Berend Sliedrecht <[email protected]> Signed-off-by: Timo Glastra <[email protected]>
…ualified-did-from-oob
Signed-off-by: Timo Glastra <[email protected]>
And various other fixes from #764