Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unqualified did from out of band record #782

Conversation

TimoGlastra
Copy link
Contributor

And various other fixes from #764

@TimoGlastra TimoGlastra requested a review from a team as a code owner May 19, 2022 17:23
@TimoGlastra TimoGlastra added this to the v0.2.0 milestone May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #782 (db4f19d) into main (f1e0412) will decrease coverage by 0.05%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   87.53%   87.47%   -0.06%     
==========================================
  Files         435      435              
  Lines       10666    10652      -14     
  Branches     1891     1880      -11     
==========================================
- Hits         9336     9318      -18     
- Misses       1268     1272       +4     
  Partials       62       62              
Impacted Files Coverage Δ
...les/connections/models/did/authentication/index.ts 100.00% <ø> (ø)
...modules/connections/repository/ConnectionRecord.ts 95.74% <ø> (ø)
.../core/src/modules/credentials/CredentialsModule.ts 91.23% <0.00%> (-0.48%) ⬇️
...les/credentials/protocol/v1/V1CredentialService.ts 88.10% <0.00%> (-0.22%) ⬇️
...les/credentials/protocol/v2/V2CredentialService.ts 93.60% <0.00%> (-0.26%) ⬇️
...s/protocol/v2/handlers/V2OfferCredentialHandler.ts 70.00% <0.00%> (-1.80%) ⬇️
.../modules/credentials/services/CredentialService.ts 100.00% <ø> (ø)
...core/src/modules/oob/repository/OutOfBandRecord.ts 100.00% <ø> (ø)
...s/protocol/v1/handlers/V1OfferCredentialHandler.ts 68.29% <33.33%> (-2.76%) ⬇️
.../connections/handlers/ConnectionResponseHandler.ts 81.25% <50.00%> (-2.09%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e0412...db4f19d. Read the comment docs.

Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, just some nits about the code nothing blocking or major.

packages/core/src/agent/MessageSender.ts Show resolved Hide resolved
packages/core/src/agent/MessageSender.ts Show resolved Hide resolved
packages/core/src/modules/oob/OutOfBandModule.ts Outdated Show resolved Hide resolved
packages/core/src/utils/did.ts Show resolved Hide resolved
Co-authored-by: Berend Sliedrecht <[email protected]>

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra enabled auto-merge (squash) May 25, 2022 10:05
@TimoGlastra TimoGlastra merged commit 0c1423d into openwallet-foundation:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants