-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jsonld-credentials #718
feat: jsonld-credentials #718
Conversation
46b1e51
to
d600ef1
Compare
@TimoGlastra I missed this during development, but apparently one of our external dependencies ( I'm not why this requirement is there yet. However, the dependency isn't that big, so we might be able to fix it by pulling it into AFJ and make some compatibility modifications. |
Node 12 will reach EOL on 2022-04-30 (tomorrow) so I'm fine with dropping support for node12. However looking at the code the usage of the verification key library is so minimal I'd like to remove it either way. The number of dependencies this PR adds is non-trivial and If possible it would be great to remove a few before merging (I think by removing the verification key and context dependencies we can drop 4 dependencies) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @karimStekelenburg! Left quite some comments, but most are cosmetic / cleanup.
packages/core/src/modules/vc/models/credential/CredentialSchema.ts
Outdated
Show resolved
Hide resolved
packages/core/src/modules/vc/models/credential/W3cCredentialState.ts
Outdated
Show resolved
Hide resolved
I merged #684 and set the target of this branch to |
@TimoGlastra not sure what you mean 'just the type'. You mean we shouldn't update the context? Didn't understand what you meant by sending the link either. |
Jup, much better indeed 🚀 |
It's type not @type |
Fixed latest comments in beeaf68. |
packages/core/src/modules/dids/__tests__/__fixtures__/didKeyBls12381g1.json
Outdated
Show resolved
Hide resolved
20f5200
to
113cbb9
Compare
a702e95
to
c907d01
Compare
@TimoGlastra done fixing the issues, we should be ready to go. |
DCO is failing |
Isn't that automatically fixed when squashing? |
Well yes, but we can't merge without. The squash would only be valid if all commits that went into the squash are signed off |
Signed-off-by: Karim <[email protected]>
70d955f
to
7e26829
Compare
Had to manually merge this into 0.3.0-pre due to some fun conflicts, but I think we're good! |
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Signed-off-by: Karim Stekelenburg <[email protected]>
Adds the low-level functionality that is required for the issuance and verification of JSON-LD based credentials (W3C).
The key features this PR includes are:
W3cCredentialService
that can be used for signing and verifying JSON-LD based credentials and presentations.W3cCredentialRepository
that handles storage for JSON-LD based credentials.Ed25519Signature2018
signature suite that adds support for signing and verifying Ed255192018 signatures.BbsBlsSignature2020
signature suite that adds support for signing and verifying BbsBls2020 signatures.BbsBlsSignatureProof2020
signature suite that adds support for deriving, signing and verifying proofs of BbsBls2020 signed credentials.