Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed check for senderkey for connectionless exchange #555

Merged
merged 2 commits into from
Dec 1, 2021

Conversation

janrtvld
Copy link
Contributor

@janrtvld janrtvld commented Nov 30, 2021

Trinsic doesn't send the senderVerkey on a connectionless exchange.

janrtvld added 2 commits November 27, 2021 12:01
Signed-off-by: janrtvld <[email protected]>
@janrtvld janrtvld requested a review from a team as a code owner November 30, 2021 13:32
@janrtvld janrtvld changed the title Removed check for senderkey for connectionless exchange refactor: removed check for senderkey for connectionless exchange Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #555 (0c9fe0b) into main (dee03e3) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #555   +/-   ##
=======================================
  Coverage   86.01%   86.01%           
=======================================
  Files         267      267           
  Lines        5840     5840           
  Branches      951      951           
=======================================
  Hits         5023     5023           
  Misses        814      814           
  Partials        3        3           
Impacted Files Coverage Δ
.../modules/connections/services/ConnectionService.ts 95.87% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee03e3...0c9fe0b. Read the comment docs.

@TimoGlastra TimoGlastra changed the title refactor: removed check for senderkey for connectionless exchange fix: removed check for senderkey for connectionless exchange Dec 1, 2021
@TimoGlastra TimoGlastra merged commit ba3f17e into openwallet-foundation:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants