fix(core): log errors if message is undeliverable #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message being logged just indicated that a message is underliverable to a certain connection. It swallowed the underlying errors. This adds an `errors` property to the error log so that it is clear what the underlying errors are when a message is underliverable. Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 86.27% 86.26% -0.01%
==========================================
Files 266 266
Lines 5762 5767 +5
Branches 931 931
==========================================
+ Hits 4971 4975 +4
- Misses 790 791 +1
Partials 1 1
Continue to review full report at Codecov.
|
berendsliedrecht
approved these changes
Nov 8, 2021
Signed-off-by: Timo Glastra <[email protected]> Co-authored-by: Berend Sliedrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message being logged just indicated that a message is underliverable to a certain connection. It swallowed the underlying errors. This adds an
errorsproperty to the error log so that it is clear what the underlying errors are when a message is underliverable.Signed-off-by: Timo Glastra [email protected]