Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix empty error log in console logger #524

Merged

Conversation

TimoGlastra
Copy link
Contributor

The console logger stringified the data object. Appereantly the Error class has no enumerable properties which means it will be stringified as an empty object. This fix checks if a (top level) value being transformed is an error and will transform the non-enumerable properties of the error.

Signed-off-by: Timo Glastra [email protected]

The console logger stringified the data object. Appereantly the Error class has no enumerable properties which means it will be stringified as an empty object. This fix checks if a (top level) value being transformed is an error and will transform the non-enumerable properties of the error.

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra requested a review from a team as a code owner November 7, 2021 14:59
@TimoGlastra TimoGlastra marked this pull request as draft November 7, 2021 15:07
@TimoGlastra TimoGlastra marked this pull request as ready for review November 7, 2021 15:18
@TimoGlastra TimoGlastra merged commit 7d9c541 into openwallet-foundation:main Nov 8, 2021
@TimoGlastra TimoGlastra deleted the fix-error-not-logged branch March 10, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants