Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core)!: simplify get creds for proof api #523

Merged

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Nov 7, 2021

BREAKING CHANGE: The ProofsModule.getRequestedCredentialsForProofRequest expected some low level message objects as input. This is not in line with the public API of the rest of the framework and has been simplified to only require a proof record id and optionally a boolean whether the retrieved credentials should by filtered based on the proof proposal (if avaiable).

Signed-off-by: Timo Glastra [email protected]

Maintainers: Before merging and squashing make sure to copy the BREAKING CHANGE entry to the commit message field, this is needed for automatic tracking of breaking changes

BREAKING CHANGE: The `ProofsModule.getRequestedCredentialsForProofRequest` expected some low level message objects as input. This is not in line with the public API of the rest of the framework and has been simplified to only require a proof record id and optionally a boolean whether the retrieved credentials should by filtered based on the proof proposal (if avaiable).

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra requested a review from a team as a code owner November 7, 2021 13:29
@TimoGlastra TimoGlastra enabled auto-merge (squash) November 7, 2021 13:30
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #523 (99ecc7d) into main (e50b821) will decrease coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   86.32%   86.27%   -0.06%     
==========================================
  Files         266      266              
  Lines        5749     5769      +20     
  Branches      923      936      +13     
==========================================
+ Hits         4963     4977      +14     
- Misses        785      791       +6     
  Partials        1        1              
Impacted Files Coverage Δ
packages/core/src/modules/proofs/ProofsModule.ts 86.25% <77.77%> (-0.84%) ⬇️
...ckages/core/src/transport/HttpOutboundTransport.ts 10.81% <0.00%> (-1.32%) ⬇️
packages/core/src/agent/AgentConfig.ts 94.44% <0.00%> (-0.11%) ⬇️
packages/core/src/wallet/IndyWallet.ts 69.17% <0.00%> (ø)
...ules/routing/services/MediationRecipientService.ts 77.77% <0.00%> (ø)
...modules/connections/repository/ConnectionRecord.ts 98.43% <0.00%> (+0.02%) ⬆️
packages/core/src/agent/Agent.ts 97.97% <0.00%> (+0.04%) ⬆️
.../modules/connections/services/ConnectionService.ts 95.87% <0.00%> (+0.08%) ⬆️
...les/basic-messages/services/BasicMessageService.ts 90.90% <0.00%> (+0.43%) ⬆️
.../core/src/modules/connections/ConnectionsModule.ts 73.80% <0.00%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50b821...99ecc7d. Read the comment docs.

@TimoGlastra TimoGlastra disabled auto-merge November 7, 2021 15:08
@TimoGlastra TimoGlastra marked this pull request as draft November 7, 2021 15:08
@TimoGlastra TimoGlastra removed the request for review from a team November 7, 2021 15:08
@TimoGlastra TimoGlastra marked this pull request as ready for review November 7, 2021 15:45
@TimoGlastra TimoGlastra merged commit ba9698d into openwallet-foundation:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make getRequestedCredentialsForProofRequest more in line with other methods
3 participants