feat(core): update agent label and imageUrl plus per connection label and imageUrl #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2021 08:15
Signed-off-by: janrtvld <[email protected]>
…nd request Signed-off-by: janrtvld <[email protected]>
janrtvld
changed the title
janrtvld
changed the title
|
Nice! Great addition. I was really missing this feature. |
TimoGlastra
reviewed
Nov 2, 2021
| public async createRequest(connectionId: string): Promise<ConnectionProtocolMsgReturnType<ConnectionRequestMessage>> { | ||
| public async createRequest( | ||
| connectionId: string, | ||
| myLabel?: string |
There was a problem hiding this comment.
I'd add the myLabel in a config like the other ones. This will make it easier to extend with more properties later on (e.g. the imageUrl)
Signed-off-by: janrtvld <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #516 +/- ##
==========================================
+ Coverage 86.25% 86.27% +0.01%
==========================================
Files 266 266
Lines 5755 5762 +7
Branches 925 931 +6
==========================================
+ Hits 4964 4971 +7
Misses 790 790
Partials 1 1
Continue to review full report at Codecov.
|
TimoGlastra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#506
This pr contains:
I would also like to add support for a custom imageUrl on connection/label, but before that i would like some feedback on this draft.