Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): do not throw error on timeout in http #512

Merged

Conversation

TimoGlastra
Copy link
Contributor

Signed-off-by: Timo Glastra [email protected]

@TimoGlastra TimoGlastra requested a review from a team as a code owner November 1, 2021 16:52
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #512 (db6ef97) into main (e50b821) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
- Coverage   86.32%   86.25%   -0.08%     
==========================================
  Files         266      266              
  Lines        5749     5754       +5     
  Branches      923      925       +2     
==========================================
  Hits         4963     4963              
- Misses        785      790       +5     
  Partials        1        1              
Impacted Files Coverage Δ
...ckages/core/src/transport/HttpOutboundTransport.ts 10.81% <0.00%> (-1.32%) ⬇️
packages/core/src/wallet/IndyWallet.ts 68.42% <0.00%> (-0.76%) ⬇️
.../modules/connections/services/ConnectionService.ts 95.78% <0.00%> (ø)
...ules/routing/services/MediationRecipientService.ts 77.77% <0.00%> (ø)
...modules/connections/repository/ConnectionRecord.ts 98.43% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e50b821...db6ef97. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 4e73a7b into openwallet-foundation:main Nov 1, 2021
@TimoGlastra TimoGlastra deleted the http-outbound-timeout branch November 1, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants