Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core)!: added basic message sent event #507

Merged

Conversation

NeilSMyers
Copy link
Contributor

@NeilSMyers NeilSMyers commented Oct 28, 2021

Signed-off-by: NeilSMyers [email protected]

Created BasicMessageSentEvent. created in tandem with an update to AFJ/react-hooks and will need to be merged before that PR can be

@NeilSMyers NeilSMyers requested a review from a team as a code owner October 28, 2021 19:41
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021

Codecov Report

Merging #507 (52665b0) into main (9fda24e) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   86.42%   86.25%   -0.18%     
==========================================
  Files         266      266              
  Lines        5739     5755      +16     
  Branches      923      925       +2     
==========================================
+ Hits         4960     4964       +4     
- Misses        778      790      +12     
  Partials        1        1              
Impacted Files Coverage Δ
...e/src/modules/basic-messages/BasicMessageEvents.ts 100.00% <100.00%> (ø)
...les/basic-messages/services/BasicMessageService.ts 90.90% <100.00%> (+0.43%) ⬆️
packages/core/src/modules/proofs/ProofsModule.ts 87.09% <0.00%> (-2.91%) ⬇️
...ckages/core/src/transport/HttpOutboundTransport.ts 10.81% <0.00%> (-1.32%) ⬇️
...s/core/src/modules/proofs/services/ProofService.ts 86.55% <0.00%> (-1.22%) ⬇️
packages/core/src/modules/ledger/index.ts 100.00% <0.00%> (ø)
packages/core/src/modules/proofs/ProofState.ts 100.00% <0.00%> (ø)
.../modules/connections/services/ConnectionService.ts 95.78% <0.00%> (ø)
...ules/routing/services/MediationRecipientService.ts 77.77% <0.00%> (ø)
...modules/connections/repository/ConnectionRecord.ts 98.43% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fda24e...52665b0. Read the comment docs.

@TimoGlastra
Copy link
Contributor

LGTM @NeilSMyers, but it seems the validation and linting is failing

@TimoGlastra TimoGlastra changed the title added basic message sent event feat(core)!: added basic message sent event Nov 1, 2021
@NeilSMyers
Copy link
Contributor Author

LGTM @NeilSMyers, but it seems the validation and linting is failing

There we go! forgot to update the tests

@TimoGlastra TimoGlastra merged commit d2c04c3 into openwallet-foundation:main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants