Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export indy pool config #504

Conversation

TimoGlastra
Copy link
Contributor

it is used in public config so should be exported

Signed-off-by: Timo Glastra [email protected]

it is used in public config so should be exported

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra requested a review from a team as a code owner October 26, 2021 08:38
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #504 (bd289df) into main (47149bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #504   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files         266      266           
  Lines        5733     5734    +1     
  Branches      923      923           
=======================================
+ Hits         4954     4955    +1     
  Misses        778      778           
  Partials        1        1           
Impacted Files Coverage Δ
packages/core/src/modules/ledger/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47149bc...bd289df. Read the comment docs.

Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesKEbert JamesKEbert merged commit b1e2b8c into openwallet-foundation:main Oct 29, 2021
@TimoGlastra TimoGlastra deleted the fix/export-indy-pool-config branch March 10, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants