Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): store mediator id in connection record #503

Merged

Conversation

TimoGlastra
Copy link
Contributor

Signed-off-by: Timo Glastra [email protected]

@TimoGlastra TimoGlastra requested a review from a team as a code owner October 21, 2021 15:06
@TimoGlastra TimoGlastra linked an issue Oct 22, 2021 that may be closed by this pull request
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@TimoGlastra TimoGlastra enabled auto-merge (squash) October 31, 2021 12:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #503 (766a9c3) into main (e5aedd0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   86.31%   86.33%   +0.01%     
==========================================
  Files         266      266              
  Lines        5749     5750       +1     
  Branches      923      924       +1     
==========================================
+ Hits         4962     4964       +2     
+ Misses        786      785       -1     
  Partials        1        1              
Impacted Files Coverage Δ
...modules/connections/repository/ConnectionRecord.ts 98.43% <100.00%> (+0.02%) ⬆️
.../modules/connections/services/ConnectionService.ts 95.78% <100.00%> (ø)
...ules/routing/services/MediationRecipientService.ts 77.77% <100.00%> (ø)
packages/core/src/wallet/IndyWallet.ts 69.17% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5aedd0...766a9c3. Read the comment docs.

@TimoGlastra TimoGlastra merged commit da51f2e into openwallet-foundation:main Oct 31, 2021
@TimoGlastra TimoGlastra deleted the feat/add-mediator-id branch March 10, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add mediator id to connection record
3 participants