fix(core): send messages now takes a connection id #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Berend Sliedrecht <[email protected]>
TimoGlastra
reviewed
Oct 19, 2021
| public async sendMessage(connection: ConnectionRecord, message: string) { | ||
| public async sendMessage(connectionId: string, message: string) { | ||
| const connection = await this.connectionService.getById(connectionId) | ||
|
|
||
| const outboundMessage = await this.basicMessageService.send(message, connection) |
There was a problem hiding this comment.
If you're on it:
Not sure if this is 100% valid code, but the basic message service is still creating the outbound message which in other modules is handled at the module layer
Suggested change
| const outboundMessage = await this.basicMessageService.send(message, connection) | |
| const basicMessage = await this.basicMessageService.createBasicMessage(content) | |
| const outboundMessage = createOutboundMessage(basicMessage, connection) |
There was a problem hiding this comment.
Will check it!
There was a problem hiding this comment.
@TimoGlastra I implemented your suggested change, however the createMessage requires a connectionRecord/connectionId to initialize and save a basicMessageRecord.
See my proposed solution in the latest commit.
Signed-off-by: Berend Sliedrecht <[email protected]>
berendsliedrecht
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Berend Sliedrecht [email protected]