fix(core): convert legacy prefix for inner msgs #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds legacy type prefix support for CredentialPreview, PresentationPreview and SignatureDecorator. It does this by converting replacing the `did:sov:BzCbsNYhMrjHiqZDTUASHg;spec` legacy prefix with the newer `https://didcomm.org` prefix. Signed-off-by: Karim Stekelenburg <[email protected]>
TimoGlastra
changed the title
TimoGlastra
approved these changes
Oct 7, 2021
|
Nice! |
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 85.75% 85.76% +0.01%
==========================================
Files 254 254
Lines 5516 5522 +6
Branches 892 892
==========================================
+ Hits 4730 4736 +6
Misses 785 785
Partials 1 1
Continue to review full report at Codecov.
|
Signed-off-by: Karim Stekelenburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds legacy type prefix support for CredentialPreview,
PresentationPreview and SignatureDecorator.
It does this by replacing the
did:sov:BzCbsNYhMrjHiqZDTUASHg;speclegacy prefix with the newerhttps://didcomm.orgprefix.Signed-off-by: Karim Stekelenburg [email protected]