Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add option check to attribute constructor #450

Conversation

TimoGlastra
Copy link
Contributor

Signed-off-by: Timo Glastra [email protected]

@TimoGlastra TimoGlastra requested a review from a team as a code owner September 1, 2021 13:13
@TimoGlastra TimoGlastra enabled auto-merge (squash) September 1, 2021 13:13
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #450 (bf073ad) into main (7e2946e) will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   85.69%   85.68%   -0.02%     
==========================================
  Files         253      253              
  Lines        5447     5448       +1     
  Branches      804      805       +1     
==========================================
  Hits         4668     4668              
- Misses        779      780       +1     
Impacted Files Coverage Δ
.../core/src/modules/proofs/models/AttributeFilter.ts 52.17% <40.00%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e2946e...bf073ad. Read the comment docs.

@TimoGlastra TimoGlastra merged commit 8aad3e9 into openwallet-foundation:main Sep 1, 2021
@TimoGlastra TimoGlastra deleted the fix/correct-serialization-attribute-filter branch October 28, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants